Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add readthedocs-flyout explicitly using position=inline #1637

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Add readthedocs-flyout explicitly using position=inline #1637

wants to merge 11 commits into from

Conversation

humitos
Copy link
Member

@humitos humitos commented Jan 16, 2025 •
edited
Loading

@humitos humitos changed the title Add an extra_nav block to inject flyout addons Add an extra block to inject flyout addons in navigation bar Jan 16, 2025
@humitos humitos mentioned this pull request Jan 16, 2025
Open
@humitos humitos marked this pull request as ready for review January 16, 2025 14:43
@humitos humitos requested a review from a team as a code owner January 16, 2025 14:43
@humitos
Inject the flyout
ca57ae3 
Inject the flyout on its position when on Read the Docs and the user defined
`flyout_display="attached"`.
@humitos
Make flyout attached by default
12000d3
@humitos humitos changed the title Add an extra block to inject flyout addons in navigation bar Add readthedocs-flyout explicitly using position=inline by default Jan 16, 2025
@humitos humitos changed the title Add readthedocs-flyout explicitly using position=inline by default Add readthedocs-flyout explicitly using position=inline Jan 16, 2025
@humitos humitos mentioned this pull request Jan 22, 2025
Open
agjohnson
agjohnson approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, though I'd double check on the scrolling issue before shipping. I'm not certain it's a problem though.

sphinx_rtd_theme/layout.html Show resolved Hide resolved
src/sass/_theme_layout.sass Outdated Show resolved Hide resolved
@humitos
Copy link
Member Author

humitos commented Jan 23, 2025

I used display: flex to make the flyout display correctly at the bottom of the navbar. Let me know if that's OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher left review comments

@agjohnson agjohnson agjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@humitos @ericholscher @agjohnson